oops! @soburi you seemed to have missed the signed-off
Do you have write access, if yes then please can you force push with your sign off?

This doesn't inspire confidence in the checkpatch checks that we have :(

We definitely need to run a CI with chekpatch:

../../../zephyr/scripts/checkpatch.pl -g HEAD
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 16 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit b94d1d7c246f ("zephyrSerial: Fix misdetection arduino_serial1") has style problems, please review.

NOTE: Ignored message types: COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES NEW_TYPEDEFS SPDX_LICENSE_TAG

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

@beriberikix can you take a look?

Do you want to implement checkpath as part of before merging this or after? Sounds like we need a separate PR either way?

@beriberikix yes it would be a seperate PR.
I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push
Another option is I will drop this commit from next and ask him to create another PR with the signoff

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

remote: error: GH006: Protected branch update failed for refs/heads/next.
remote: error: Changes must be made through a pull request. Cannot force-push to this branch
To github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git
 ! [remote rejected] next -> next (protected branch hook declined)
error: failed to push some refs to 'github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git'

I couldn't push to next.

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

done.

@soburi , sorry I don't see the signed off by in
b94d1d7 yet? Would you prefer that I drop the commit and we have a new PR?

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

done.

@soburi , sorry I don't see the signed off by in b94d1d7 yet? Would you prefer that I drop the commit and we have a new PR?

I failed to push.
Update previous comment.
#80 (comment)

@DhruvaG2000

@beriberikix yes it would be a seperate PR. I am waiting for @soburi if he has force push access then he can add his sign off to this commit and force push Another option is I will drop this commit from next and ask him to create another PR with the signoff

remote: error: GH006: Protected branch update failed for refs/heads/next.
remote: error: Changes must be made through a pull request. Cannot force-push to this branch
To github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git
 ! [remote rejected] next -> next (protected branch hook declined)
error: failed to push some refs to 'github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git'

I couldn't push to next.

Okay no worries, Ill drop this commit from next and then ask for the new PR to be made with these changes.
Closing this PR for now.

@soburi I have force pushed -next dropping the commit. Requesting you to kindly open #79 again with your signed off tag.
Thanks

@DhruvaG2000
It couldn't.

remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: error: GH006: Protected branch update failed for refs/heads/next.
remote: error: Changes must be made through a pull request.
To github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git
 ! [remote rejected] next -> next (protected branch hook declined)
error: failed to push some refs to 'github.com:zephyrproject-rtos/gsoc-2022-arduino-core.git'

@soburi one can't/shouldn't directly push to any of this repo's branches unless absolutely necessary.
Please can you make a new PR?